[foxy backport] Added executor benchmark tests (#1413)#1440
Merged
Conversation
brawner
changed the title
ahcorde
approved these changes
Nov 5, 2020
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
LGTM with green CI,
Thank you for creating the backport
brawner
force-pushed
the
brawner/rclcpp-backport-1425
branch
from
33942ff to
a999af7
Compare
* Added executor benchmark tests Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * initialize callback_count Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feddback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added add_node and remove_node benchmark tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Add/remove node in static_single_thread_executor Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Added StaticSingleThreadedExecutor add/remove node tests Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
brawner
force-pushed
the
brawner/rclcpp-backport-1413
branch
from
eb26790 to
724d0ab
Compare
Contributor
Author
|
Contributor
Author
|
Linux/macOS test failures are due to a new issue with FastDDS, resolved here: CMake warning on windows is to be expected for benchmarks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport executor benchmarks from #1413